[Spice-devel] [PATCH spice-gtk 1/4] coroutine: don't force coroutine_init checking

[Christophe Fergeau]

On Tue, Nov 19, 2013 at 05:38:29PM +0100, Marc-André Lureau wrote:
> > Hrm, all of this would have been more useful during the review of "Check
> > coroutine_init() return value" as this is an alternate approach I
> > experimented with, but then I preferred to try to avoid adding more abort()
> > to spice-gtk.
> 
> spice-gtk follows glib/gtk principle of API and failure.

If what you want to say is that coroutine creation succeeding is a
low-level "must-work" part of spice-gtk, I can agree with that, just say it
rather than using overly broad and vague sentences.


> It's not too late to fix this (and it's not too late to admit that
> G_GNUC_WARN_UNUSED_RESULT. shouldn't be used for error codes ;)

I'm still totally fine with using it internally in this very specific case.
I'm not saying this is the best alternative.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20131119/ccca43bd/attachment-0001.pgp>