[Spice-devel] [patch 1/1] fix SASL for mechanism using WANT_CLIENT_FIRST

[Christophe Fergeau]

Hey,

On Thu, Nov 07, 2013 at 03:06:45PM +0000, Dietmar Maurer wrote:
> > On Fri, Oct 25, 2013 at 10:43:13AM +0200, Christophe Fergeau wrote:
> > > On Tue, Oct 22, 2013 at 11:07:56AM +0200, dietmar at proxmox.com wrote:
> > > > Current code works with DIGEST-MD5, but not with PLAIN.
> > >
> > > After spending quite some time on this, this seems right, we need to
> > > handle
> > > sasl_client_start() returning SASL_OK and not step in this case.
> > > However, as this is under-documented in cyrus-sasl documentation, I'll
> > > ask on their mailing list first if this makes sense (and hopefully get
> > > cyrus-sasl documentation improved).
> > 
> > I haven't forgotten about this, I've sent an email, but did not get an answer (yet)
> > :-/
> 
> Yes, I noticed that ;-)
> 
> > http://asg.andrew.cmu.edu/archive/message.php?mailbox=archive.cyrus-
> > sasl&msg=10095
> > 
> > I'll eventually push your patch when I'm tired of waiting ;)
> 
> Many thanks!

I've now pushed that patch after getting confirmation from upstream that
their documentation needs some fixes. I've expanded a bit on the commit
message.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20131121/50a869db/attachment.pgp>