[Spice-devel] [PATCH spice-gtk] continuation: fix make distcheck

Christophe Fergeau cfergeau at redhat.com
Wed Nov 27 01:52:44 PST 2013


On Tue, Nov 26, 2013 at 07:41:41PM +0100, Marc-André Lureau wrote:
> Since 0508f586,  errno.h is included above #undef _FORTIFY_SOURCE.
> 
> But it must be placed above system headers to take effect
> ---
>  gtk/continuation.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/gtk/continuation.c b/gtk/continuation.c
> index d1249d6..c11d810 100644
> --- a/gtk/continuation.c
> +++ b/gtk/continuation.c
> @@ -18,10 +18,14 @@
>   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
>   */
>  #include <config.h>
> -#include <errno.h>
> -#include <glib.h>
>  
> +/* keep this above system headers, but bellow config.h */

"below"

ACK

> +#ifdef _FORTIFY_SOURCE
>  #undef _FORTIFY_SOURCE
> +#endif
> +
> +#include <errno.h>
> +#include <glib.h>
>  
>  #include "continuation.h"
>  
> -- 
> 1.8.4.2
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20131127/f047c403/attachment.pgp>


More information about the Spice-devel mailing list