[Spice-devel] [PATCH spice-gtk 2/2] display: cache id is uint64_t

Christophe Fergeau cfergeau at redhat.com
Thu Oct 3 06:26:25 PDT 2013


On Thu, Oct 03, 2013 at 01:53:56PM +0200, Marc-André Lureau wrote:
> ---
>  gtk/channel-display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gtk/channel-display.c b/gtk/channel-display.c
> index e0f17eb..a57453f 100644
> --- a/gtk/channel-display.c
> +++ b/gtk/channel-display.c
> @@ -551,7 +551,7 @@ static SpicePalette *palette_get(SpicePaletteCache *cache, uint64_t id)
>      return cache_find(c->palettes, id);
>  }
>  
> -static void palette_remove(SpicePaletteCache *cache, uint32_t id)
> +static void palette_remove(SpicePaletteCache *cache, uint64_t id)
>  {
>      SpiceDisplayChannelPrivate *c =
>          SPICE_CONTAINEROF(cache, SpiceDisplayChannelPrivate, palette_cache);

ACK. I did not manage to get gcc to warn about the implicit cast from
uint64_t to uint32_t in the palette_remove callers (tried -Wconversion)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20131003/1ce82a32/attachment.pgp>


More information about the Spice-devel mailing list