[Spice-devel] RFC on sound codec refactoring

[Gerd Hoffmann]

On Mo, 2013-10-07 at 15:03 +0200, Christophe Fergeau wrote:
> On Mon, Oct 07, 2013 at 12:26:50PM +0200, Gerd Hoffmann wrote:
> > On Mo, 2013-10-07 at 05:35 -0400, Marc-André Lureau wrote:
> > > Instead of having to resample, can't we fix qemu (and spice headers) to use 48khz by default?
> > 
> > Sure we can switch the default.  spice headers is enougth btw.  Just
> > update the frequency there.  And bumb the minor version so spice-server
> > can figure which frequency is used by qemu.
> > 
> > You can still face the case that spice-server has to handle a old
> > (not-yet rebuilt against new spice-headers) qemu binary which operates
> > at 44.1 kHz.  So the 44.1 -> 48 resampling will be needed, even when is
> > used for a (hopefully short) transition period only.
> 
> When spice-server detects that qemu hasn't been updated and is still using
> 44.1, then it could advertise it does not support Opus and only use celt
> until qemu is recompiled.

Yep, that will work too.  And it will probably handle the transition
with less code.

cheers,
  Gerd