[Spice-devel] [patch 2/3] spice-server: add push_utf8 callback to input channel

[Alon Levy]

On 10/17/2013 11:27 AM, Dietmar Maurer wrote:
>> On 10/16/2013 02:04 PM, dietmar at proxmox.com wrote:
>> For next time: can you send the patches inline? it is easier to respond to then to
>> mails with attachments.
> I guess I have already done that. I use 'quilt mail' to send the patches, and the
> raw email contains:
>
> Content-Disposition: inline;
> 	filename="add-push-utf8-callback-to-input-channel.patch"
> Content-Type: text/plain
>
> Why is that wrong?
You are right. And yet thunderbird won't show me the contents on reply, 
and I saw there was an attachment, so I assumed. My bad. Still I don't 
know why thunderbird fails to quote the message on reply and instead 
gives me an empty message.

>
>> You should increment SPICE_INTERFACE_KEYBOARD_MINOR as well to allow
>> users (qemu / spiceterm / xspice etc.) to compile to both old and new versions
>> easily (assuming they decide perhaps sometime to use the new functionality).
> OK
>