[Spice-devel] remote-viewer spice auth

[Marc-André Lureau]

Hi

----- Original Message -----
> 
> 
> Current remote viewer only ask for a password when connecting to a spice
> session
> 
> which requires auth:
> 
> 
> 
> from virt-viewer-session-spice.c:
> 
> 
> 
> case SPICE_CHANNEL_ERROR_AUTH:
> 
> DEBUG_LOG("main channel: auth failure (wrong password?)");
> 
> int ret = virt_viewer_auth_collect_credentials(self->priv->main_window,
> 
> "SPICE",
> 
> NULL,
> 
> NULL, &password);
> 
> 
> 
> I want to make it possible to do authentication using username and password.
> 
> 
> 
> Would you accept a patch for that, or do you think above code is all we need?

We shouldn't ask username for the current auth methods.

I think you could add a SPICE_CHANNEL_ERROR_AUTH_USER_AND_PASS (and a property "username" on the session)

> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>