[Spice-devel] [PATCH] Be explicit about spice-common license

Christophe Fergeau cfergeau at redhat.com
Wed Oct 23 11:43:18 CEST 2013


On Tue, Oct 22, 2013 at 10:40:33AM -0500, Jonathon Jongsma wrote:
> Use same license as spice-gtk and spice modules (LGPL 2.1) since those licenses
> applied to the spice-common submodule in the past.  This makes it more clear
> that if you use spice-common separately, the license is still LGPL.  Also
> mention license and copyright in generated files.

This commit log gives me the feeling that you forgot to git add COPYING?
ACK from me if there is a COPYING file in the commit.

Christophe

> ---
>  spice_codegen.py | 23 +++++++++++++++++++++--
>  1 file changed, 21 insertions(+), 2 deletions(-)
> 
> diff --git a/spice_codegen.py b/spice_codegen.py
> index 1cf1697..d35d949 100755
> --- a/spice_codegen.py
> +++ b/spice_codegen.py
> @@ -80,8 +80,6 @@ def write_enums(writer, describe=False):
>      writer.writeln("#ifndef _H_SPICE_ENUMS")
>      writer.writeln("#define _H_SPICE_ENUMS")
>      writer.newline()
> -    writer.comment("Generated from %s, don't edit" % writer.options["source"]).newline()
> -    writer.newline()
>  
>      # Define enums
>      for t in ptypes.get_named_types():
> @@ -173,10 +171,31 @@ writer = codegen.CodeWriter()
>  writer.header = codegen.CodeWriter()
>  writer.set_option("source", os.path.basename(proto_file))
>  
> +license = """/*
> +  Copyright (C) 2013 Red Hat, Inc.
> +
> +  This library is free software; you can redistribute it and/or
> +  modify it under the terms of the GNU Lesser General Public
> +  License as published by the Free Software Foundation; either
> +  version 2.1 of the License, or (at your option) any later version.
> +
> +  This library is distributed in the hope that it will be useful,
> +  but WITHOUT ANY WARRANTY; without even the implied warranty of
> +  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +  Lesser General Public License for more details.
> +
> +  You should have received a copy of the GNU Lesser General Public
> +  License along with this library; if not, see <http://www.gnu.org/licenses/>.
> +*/
> +
> +"""
> +
>  writer.public_prefix = options.prefix
>  
>  writer.writeln("/* this is a file autogenerated by spice_codegen.py */")
> +writer.write(license)
>  writer.header.writeln("/* this is a file autogenerated by spice_codegen.py */")
> +writer.header.write(license)
>  if not options.header and not options.generate_enums:
>      writer.writeln("#ifdef HAVE_CONFIG_H")
>      writer.writeln("#include <config.h>")
> -- 
> 1.8.3.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20131023/6a66ec85/attachment.pgp>


More information about the Spice-devel mailing list