[Spice-devel] [PATCH spice-gtk] util: do not overwrite G_MESSAGES_DEBUG=all

Christophe Fergeau cfergeau at redhat.com
Wed Oct 30 10:33:24 CET 2013


On Tue, Oct 29, 2013 at 09:30:49PM +0100, Marc-André Lureau wrote:
> glib log handler only check for a single 'all' value, mixing it with
> other domains name will disable 'all' messages.
> ---
>  gtk/spice-util.c | 2 ++
>  spice-common     | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gtk/spice-util.c b/gtk/spice-util.c
> index 6ac6af6..823d47b 100644
> --- a/gtk/spice-util.c
> +++ b/gtk/spice-util.c
> @@ -48,6 +48,8 @@ static void spice_util_enable_debug_messages(void)
>      const gchar *doms = g_getenv("G_MESSAGES_DEBUG");
>      if (!doms) {
>          g_setenv("G_MESSAGES_DEBUG", G_LOG_DOMAIN, 1);
> +    } else if (g_str_equal(doms, "all")) {
> +	return;

It would be nice to fix it in gtk-vnc as well. The proper fix belongs in
glib imo.

ACK.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20131030/c98ca689/attachment.pgp>


More information about the Spice-devel mailing list