[Spice-devel] [PATCH] Add SpiceMainChannel::monitors-config-requested signal

[Jonathon Jongsma]

----- Original Message -----
> From: "Marc-André Lureau" <mlureau at redhat.com>
> To: "Jonathon Jongsma" <jjongsma at redhat.com>
> Cc: spice-devel at freedesktop.org
> Sent: Saturday, October 26, 2013 10:31:42 AM
> Subject: Re: [Spice-devel] [PATCH] Add	SpiceMainChannel::monitors-config-requested signal
> 
> Hi,
> 
> 
> ----- Original Message -----
> > In some circumstances, when one display is in fullscreen but others are
> > not,
> > the
> > display regions can sometimes overlap (rhbz #1002156). There are other
> > cases
> > where the auto-align code lines up monitors in the wrong order because they
> > are
> > moved after they've been resized.  In general, the root cause for all of
> > these
> > problems is that the SpiceMainChannel object doesn't know the exact size
> > and
> > position of all displays at the time when it is aligning monitors and
> > sending
> > down a new configuration.  To solve this issue, introduce a new signal
> > ('monitors-config-requested') that is emitted by the main channel
> > immediately
> > before it sends down a new configuration.  Displays can listen to this
> > signal
> > and then update their current state within the signal handler so that the
> > main
> > channel has up-to-date information to use for configuring the monitors.
> 
> Instead of adding more hooks, have you thought if clients who wants to
> overwrite monitor positioning could disable spice-gtk auto-align code at
> all, and instead handle the align configuration themselves? Wouldn't that be
> more flexible since the spice-gtk code is not satisfying and hard to
> generalize correctly?
> 


I guess I agree that it's probably a better and more flexible solution, so I'll try to rework this patch in that direction.

Jonathon