[Spice-devel] [spice-gtk sound rework 3/3] Use the new snd_codec interface to process encoded audio.

[Jeremy White]

> On Wed, Oct 16, 2013 at 11:46:56AM -0500, Jeremy White wrote:
>> diff --git a/gtk/channel-playback.c b/gtk/channel-playback.c 
>> index 60fc113..bcb4728 100644 --- a/gtk/channel-playback.c +++
>> b/gtk/channel-playback.c @@ -379,18 +363,16 @@ static void
>> playback_handle_data(SpiceChannel *channel, SpiceMsgIn *in) 
>> packet->data, packet->data_size); break; case
>> SPICE_AUDIO_DATA_MODE_CELT_0_5_1: { -        celt_int16_t pcm[256
>> * 2]; +        uint8_t pcm[SND_CODEC_CELT_FRAME_SIZE * 2 * 2]; +
>> int n = sizeof(pcm);
>> 
>> -        g_return_if_fail(c->celt_decoder != NULL); - -        if
>> (celt051_decode(c->celt_decoder, packet->data, -
>> packet->data_size, pcm) != CELT_OK) { +        if
>> (snd_codec_decode(c->codec, packet->data, packet->data_size, +
>> pcm, &n) != SND_CODEC_OK) { g_warning("celt_decode() error");
> 
> The g_warning() should no longer mention celt.

Actually, I think for this patch, it should remain, because the change
is surgical - it's still clearly in a Celt only mode.

The next set of patches change that warning.  You mentioned on irc
that you encountered a crash in qemu with these patches.

Do you have any more details?

I'll wait to hear further from you before I submit the revised set of
3 patches.

Cheers,

Jeremy