[Spice-devel] [PATCH] server: bitmap_consistent: replace spice_error with spice_warning

Uri Lublin uril at redhat.com
Sun Sep 1 11:43:17 PDT 2013


bitmap_consistent should return true or false.
Currently it aborts instead of returning false, due to spice_error.
Replacing spice_error with spice_warning, provides information and returns
false, as expected.

This fixes Fedora bz#997932
---
 server/red_parse_qxl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c
index 6c0b065..e26746c 100644
--- a/server/red_parse_qxl.c
+++ b/server/red_parse_qxl.c
@@ -353,7 +353,7 @@ static int bitmap_consistent(SpiceBitmap *bitmap)
     int bpp = MAP_BITMAP_FMT_TO_BITS_PER_PIXEL[bitmap->format];
 
     if (bitmap->stride < ((bitmap->x * bpp + 7) / 8)) {
-        spice_error("image stride too small for width: %d < ((%d * %d + 7) / 8) (%s=%d)\n",
+        spice_warning("image stride too small for width: %d < ((%d * %d + 7) / 8) (%s=%d)\n",
                     bitmap->stride, bitmap->x, bpp,
                     bitmap_format_to_string(bitmap->format),
                     bitmap->format);
-- 
1.7.1



More information about the Spice-devel mailing list