[Spice-devel] [PATCH xf86-video-qxl 07/11] xspice: add uinput support to vdagent support

Jeremy White jwhite at codeweavers.com
Wed Sep 4 14:35:14 PDT 2013


> +    n = read(uinput_fd, (char *)&inp_event + offset, sizeof(inp_event) - offset);
> +    offset += n;
> +    if (offset < sizeof(inp_event)) {
> +        return;
> +    }

Nit:  you don't handle errors (I realize you're only here when select
indicates read data is present, but still...)

Cheers,

Jeremy



More information about the Spice-devel mailing list