[Spice-devel] [PATCH spice-gtk 1/4] proto: comment future surface flags usage

Christophe Fergeau cfergeau at redhat.com
Wed Sep 11 02:12:28 PDT 2013


On Tue, Sep 10, 2013 at 04:43:36PM +0200, Marc-André Lureau wrote:
> ---
>  spice.proto | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/spice.proto b/spice.proto
> index 5eede6b..8aa35c1 100644
> --- a/spice.proto
> +++ b/spice.proto
> @@ -425,6 +425,8 @@ flags8 string_flags {
>  };
>  
>  flags32 surface_flags {
> +    /* Adding flags requires some caps check, since old clients only
> +       treat this value as an enum (== PRIMARY test) */

maybe 'treat this value as an enum (== PRIMARY test) rather than a bit
field' would make things clearer when someone reads this comment in 2
years?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20130911/e4227144/attachment.pgp>


More information about the Spice-devel mailing list