[Spice-devel] [PATCH 00/11] fix spicec gl_fbo

[Alon Levy]

On 09/24/2013 02:42 PM, Marc-André Lureau wrote:
> Hi,
>
> Please find a few patches fixing gl_fbo usage and glitches.
>
> spice-common needs to be updated too, with the opengl related fixes.
> (the submodule update will be done before, so ignore updates during
> review of these patches please)

Looks good to me. My last comment was a question, so ack regardless of 
the answer.

>
> Marc-André Lureau (11):
>    spicec: warn when throwing exception
>    spicec: use standard opengl 3.0 framebuffer
>    spicec: fix non-doublebuffer drawing
>    spicec: use doublebuffer for opengl
>    spicec: remove dead GL code
>    spicec: add SPICE_NOGRAB
>    spicec: do not abort if cache error
>    spicec: add sw canvas diff check
>    spicec: use pre/post copy
>    spicec: disable stencil test with primary fbo
>    spicec: refresh the display after display resize
>
>   client/cache.hpp             |  3 +-
>   client/display_channel.cpp   | 92 ++++++++++++++++++++++++++++++++------------
>   client/display_channel.h     |  2 +
>   client/red_gl_canvas.cpp     |  2 +
>   client/red_pixmap.h          | 19 +++++++++
>   client/red_window.h          |  2 +
>   client/screen.cpp            |  1 +
>   client/utils.h               |  6 +++
>   client/x11/pixels_source_p.h |  1 +
>   client/x11/platform.cpp      |  3 +-
>   client/x11/red_drawable.cpp  | 13 ++++---
>   client/x11/red_pixmap_gl.cpp | 85 ++++++++++++++++++++--------------------
>   client/x11/red_window.cpp    | 50 +++++++++---------------
>   client/x11/red_window_p.h    |  3 --
>   spice-common                 |  2 +-
>   15 files changed, 176 insertions(+), 108 deletions(-)
>