[Spice-devel] [Spice-commits] configure.ac

[Christophe Fergeau]

Hey,

On Mon, Mar 31, 2014 at 01:04:05PM -0700, Jonathon Jongsma wrote:
>  configure.ac |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> New commits:
> commit 4f8b8b1581d257f14f46628703932f10834f488e
> Author: Jonathon Jongsma <jjongsma at redhat.com>
> Date:   Mon Mar 31 14:59:39 2014 -0500
> 
>     Fix missing SPICE_GTK_MICRO_VERSION value
>     
>     configure.ac tries to assign a default value of 0 to the micro version if it's
>     empty, but the shell variable assignemnt doesn't work because there's whitespace
>     around the '=' sign.
>     
>     This results in SPICE_GTK_MICRO_VERSION being defined to (), which causes a
>     compilation failure in files that include it.

Ah, did this happen with a tarball?
I knew this bit was untested when I sent the patch, but when building from
git SPICE_GTK_MICRO_VERSION is always set, so I assumed it would never be
empty in real world situations, did not think of tarballs :)

Thanks,

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140401/916b58a1/attachment.sig>