[Spice-devel] [PATCH spice-gtk 06/14] win-usb: throw an error if reply.status != 0

[Marc-André Lureau]

On Thu, Apr 24, 2014 at 4:50 PM, Jonathon Jongsma <jjongsma at redhat.com>wrote:

> I have no experience with usbclerk, but reading the code, it seems that
> reply.status is set to a boolean value[1], with true meaning success.  So
> the status!=0 below appears to be backward.  Or am I reading it wrong?


oops my bad, it should be:

 if (!priv->reply.status)

same as currently in gtk/usb-device-manager.c:

  if (!status) {
        g_warning("failed to %s win usb driver (status=0)", opstr);
    }




-- 
Marc-André Lureau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140424/c070e15a/attachment-0001.html>