[Spice-devel] [PATCH] Make use of the new playback rate interface, if available.

[Christophe Fergeau]

Hey,

This has been pushed already, but I had one question:

On Mon, Apr 21, 2014 at 09:39:49AM -0500, Jeremy White wrote:
> ---
>  src/spiceqxl_audio.c |   13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/src/spiceqxl_audio.c b/src/spiceqxl_audio.c
> index 5b87302..7afc089 100644
> --- a/src/spiceqxl_audio.c
> +++ b/src/spiceqxl_audio.c
> @@ -330,11 +335,17 @@ qxl_add_spice_playback_interface (qxl_screen_t *qxl)
>      if (ret < 0)
>          return errno;
>  
> +#if SPICE_INTERFACE_PLAYBACK_MAJOR > 1 || SPICE_INTERFACE_PLAYBACK_MINOR >= 3
> +    spice_server_set_playback_rate(&qxl->playback_sin,
> +            spice_server_get_best_playback_rate(&qxl->playback_sin));
> +#else
>      /* disable CELT */
>      ret = spice_server_set_playback_compression(qxl->spice_server, 0);
>      if (ret < 0)
>          return errno;

This codepath disables compression for some reason, should we do the
same in the newer codepath?

Christophe