[Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless device ref/unref

[Uri Lublin]

On 04/28/2014 03:49 PM, Marc-André Lureau wrote:
>
> ----- Original Message -----
>> On 04/23/2014 09:09 PM, Marc-André Lureau wrote:
>>> A code doing an unref() on an object just before manipulating it looks
>>> horribly suspicious...
>> Suspicious indeed.
>>
>> But probably it's better to move the unref below instead of removing the
>> ref/unref (see below).
>>
>> A device is ref'ed when install/uninstall starts and is unref'ed when
>> install/uninstall finishes.
>>
>> Possibly during install the ref is not needed (as there is another ref
>> for the redir operation),
>> but I think it is needed during uninstall.
>>
> It wasn't needed until now (or we would have had crashes before), why would it be now?

Generally, no crashes does not mean ref/unref are not needed.