[Spice-devel] [PATCH spice-gtk 00/14] USB fail early on win32 without usbclerk

[Uri Lublin]

On 04/28/2014 01:39 PM, Marc-André Lureau wrote:
>
> Hi
>
> On Mon, Apr 28, 2014 at 12:35 PM, Uri Lublin <uril at redhat.com 
> <mailto:uril at redhat.com>> wrote:
>
>     On 04/23/2014 09:09 PM, Marc-André Lureau wrote:
>
>         Hi,
>
>         Here is a small series, of little cleanups, and of goal to
>         throw early
>         an error when the win32 usbclerk can't be reached. In turn,
>         the error
>         can be catched by client code to show a useful dialog.
>
>
>     Hi Marc-Andre,
>
>     Thanks for taking the time to cleanup the usb code.
>
>     Currently users can manually install the WinUSB driver for devices and
>     usbredir those devices without installing usbclerk.
>     That's why spice-gtk tries to usbredir a device even if WinUSB
>     installation fails.
>
>     Does that hold with this patch-set too ?
>
>     (I don't know if there are users that actually install the driver
>     manually,
>     or if it's worth keeping that behavior).
>
>
> I wasn't aware of this behavior. Is it documented somewhere? Is it 
> really worth keeping? Imho, if it's not user friendly, we better not 
> support it, than to keep code that theorically could do that, but we 
> never try, while for the rest of us it appears to be broken when 
> usbclerk isn't installed.

I mentioned it a few times on the mailing list.
I don't know what method users prefer.

In the future we want to use a filter driver instead of the WinUSB 
driver. When that happens, we would
not need usbclerk. When we'd have the filter driver, and when that 
driver is not installed, it would be
nice to disable usbredir, so I think your patch-set is moving in the 
right direction.

Thanks,
     Uri.