[Spice-devel] [PATCH] migration: Don't assert() if MIGRATE_DATA comes before attaching the agent

[Christophe Fergeau]

Hey,

On Wed, Jul 23, 2014 at 12:16:55AM +0300, Uri Lublin wrote:
> This patch fixes an assert in spice-server code on the
> destination side of migration, that happens when
> the MIGRATE_DATA message of the main channel arrives
> before the (qemu-kvm's) virtio-serial-port device state.
> For a more detailed information look at the patch
> log message.
> 
> Some comments/concerns about this patch:
> 1. Some more testing needs to be done.
>    To test it, the MIGRATE_DATA message needs to arrive first.
>    One way to achieve that is to make the migration socket
>    between the two hosts slower.
>    Another is to add some sleeps in the other path of the code, which
>    is what I did.

Could you add a diff of the sleeps you added to trigger that bug to the
commit log? This will be very helpful if we want to try and reproduce it
in the future.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140807/14340239/attachment.sig>