[Spice-devel] [PATCH] [spice-gtk] DND: fix special case that file size is 0

[Marc-André Lureau]

----- Original Message -----
> 
> 
> 
> On Tue, Aug 12, 2014 at 12:58 AM, Marc-André Lureau < mlureau at redhat.com >
> wrote:
> 
> 
> 
> 
> ----- Original Message -----
> > On windows guest, after dra gging a zero-size file, the file will be
> > occupied
> > by vdagent. For spice-gtk ignores this case, and stops sending data after
> > sending
> > a start message to agent, see here for more details:
> > http://lists.freedesktop.org/archives/spice-devel/2014-August/017184.html
> > I accept the suggestion of Christophe and fix the bug in spice-gtk.
> > Pay attention to the modification of
> > ​
> > agent_msg_queue_many, I think it's a small trick.
> 
> Isn't this changing the protocol?
> 
> We use to send xfer-start of data size 0 and then xfer-data of data size 0,
> and now we skip the second part.
> 
> That's an an incompatible change. I would prefer if we keep sending the
> xfer-data message, even if it is of size 0.
> 
> Or if you prefer don't initiate xfer at all if the file size is 0. But I
> don't think that's worth it, and it would be some "racy" code (check size
> before doing actual operation)
> ​You mean client shouldn't send a zero-size file?I think sending such file is
> ​meaningless, too.
> And I prefer this can be fixed through a more comfortable way.

I was talking from a protocol pov. But actually, sending 0-size file is meaningful in some cases. So it should keep sending it.