[Spice-devel] [PATCH] Wait to send monitor config until agent caps are received

Marc-André Lureau mlureau at redhat.com
Thu Aug 28 09:57:49 PDT 2014



----- Original Message -----
> > > To solve the issue, we trigger a display update when the agent becomes
> > > connected, but give it a long timeout (e.g. 5 seconds). This gives some
> > > time
> > 
> > To avoid the timeout, we could rely on the agent caps reply to happen
> > right after sending the client caps->request, no?
> 
> Perhaps I don't understand your suggestion, but this 5-second timeout is
> only to handle the case where the server doesn't actually send an agent
> caps message. In the normal case (where the server sends its
> capabilities), there will be no timeout because we'll trigger a display
> update immediately after receiving the agent caps reply...


Yes, but what if the reply doesn't come after 5s, we will still get the same bugs I suppose.

As you may agree, it's best to avoid timers (some exceptions are those that are user or HI related timers, such as the delay timer for monitor resize)


More information about the Spice-devel mailing list