[Spice-devel] [PATCH spice] dispatcher: lower a monitor-config warning to a debug level

[Christophe Fergeau]

ACK

On Fri, Aug 29, 2014 at 01:15:54PM +0200, Marc-André Lureau wrote:
> Some QXLInterface implementations might not have or succeed
> with client_monitors_config(). Thus, lower warning to debug
> level.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1119220
> ---
>  server/red_dispatcher.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c
> index fd6c2e1..a6ffe7b 100644
> --- a/server/red_dispatcher.c
> +++ b/server/red_dispatcher.c
> @@ -332,8 +332,8 @@ void red_dispatcher_client_monitors_config(VDAgentMonitorsConfig *monitors_confi
>          if (!now->qxl->st->qif->client_monitors_config ||
>              !now->qxl->st->qif->client_monitors_config(now->qxl,
>                                                         monitors_config)) {
> -            spice_warning("spice bug: QXLInterface::client_monitors_config"
> -                          " failed/missing unexpectedly\n");
> +            /* this is a normal condition, some qemu devices might not implement it */
> +            spice_debug("QXLInterface::client_monitors_config failed\n");
>          }
>          now = now->next;
>      }
> -- 
> 1.9.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140829/1aec1058/attachment.sig>