[Spice-devel] [spice-common 00/13] Improvements to spice-common configure.ac/Makefile.am

[Marc-André Lureau]

hi

----- Original Message -----
> Hey, this patch series refactors the content of configure.ac of spice-common,
> and
> makes a few cleanups of Makefile.am. The reason for these changes is that I'd
> like to
> introduce a SPICE_COMMON_SETUP m4 macro which could be used by
> spice-gtk/spice-server
> to setup the spice-common build tree without invoking spice-common/configure.
> It would
> also be possible to call this macro from the current configure.ac coming with
> spice-common
> so that it can be made standalone in the future.

It is already standalone. It would be nice to keep it that way.

> 
> It also removes spice-protocol as a submodule, which means you need to 'make
> install' it after making some changes. As spice-protocol is an API stable
> module with regular upstream releases, I think it's better not to ship a
> random snapshot of it with spice-server/spice-gtk releases.

That's pretty annoying, since as you said it is a stable module, _every change_ would deserve a release in order to be useful in any of the Spice projects.

What is the problem you are trying to solve by removing submodule? I remember it install the protocol files, but noone reported bugs. This is probably something that can be fixed instead.

I would rather keep spice-protocol as a submodule because it is actually convenient when you are accustomed to it (btw, qemu has 12 of those iirc for ex - I know many projects who seem happy enough with it)