[Spice-devel] [spice-common 10/13] build-sys: Remove automatic generation of enums.h

[Christophe Fergeau]

On Wed, Dec 03, 2014 at 01:12:56PM -0500, Marc-André Lureau wrote:
> hi
> 
> ----- Original Message -----
> > Now that spice-protocol is no longer a submodule, it's no longer
> > possible to automatically overwrite enums.h within the spice-protocol
> > submodule when spice.proto changes in the spice-common module.
> > 
> > This commit replaces this with manual generation of this file with
> > 'make -C common/ enums.h'
> > This enums.h file is shipped by spice-protocol, and contains enum
> > definitions used by the SPICE protocol. It's generated from the
> > spice.proto/spice1.proto files, so must be updated whenever they change.
> 
> Reading this I wonder if we shouldn't merge back spice-protocol in
> spice-common. I am not sure the current split brings anything.

We should go towards less bundling, not more. spice-vdagent and the qxl
driver uses spice-protocol as an external dependency, and don't need
spice-common at all.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141204/c48baceb/attachment.sig>