[Spice-devel] [PATCH spice-protocol] build-sys: simplify autogen

[Christophe Fergeau]

On Thu, Dec 04, 2014 at 12:09:15PM -0500, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > On Thu, Dec 04, 2014 at 05:59:07PM +0100, Marc-André Lureau wrote:
> > > On Thu, Dec 4, 2014 at 5:53 PM, Christophe Fergeau <cfergeau at redhat.com>
> > > wrote:
> > > > Replacing autogen.sh with a totally different one is _not_ something
> > > > trivial.
> > > 
> > > It is to me, it took me about a minute to do all that. It is also
> > > trivial to remove it or change it. Do you have something to say about
> > > the change itself?
> > 
> > Yes, that it should not have been pushed.
> 
> Can you please say why?

Your question seems to be based on the assumption that "If something is
pushed with no review, and if noone has anything to say about it, then
it was fine to push it in the first place". Since this patch does not
qualify for the trivial rule or whatever, it had no reason to be pushed
in the first place.
Whether there are review comments or not is irrelevat to the point I'm
making.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141204/9692fe84/attachment.sig>