[Spice-devel] [PATCH spice-protocol] build-sys: simplify autogen

[Christophe Fergeau]

Hey,

On Fri, Dec 05, 2014 at 08:46:16AM -0500, Marc-André Lureau wrote:
> ----- Original Message -----
> > >>> Yes, that it should not have been pushed.
> > 
> > I agree.
> > 
> > I would prefer we eliminated the trivial push rule altogether.
> 
> I agree, if it can help to avoid this kind of endless discussion.
> 
> But to me, it makes the project less friendly if people have no trust
> to each other for the most basic and obvious improvements.

Basic, obvious is very subjective...  It's not a matter of trusting
people or not (I'm the person I trust the least, even for the most
trivial change btw), it's a matter of improving the quality of commits
with reviews. Even the most basic commit can have a typo in its commit
message.

> I am not talking about controversial or complicated fixes. But doc
> addition, build-sys, cleaning, spelling: this all qualifies to
> something that is an obvious improvement that I can trust people who
> have commit access to do the right call.

The spice-protocol submodule removal is an obvious improvement (to me),
and is only making build-sys related changes, but pushing it without
review would have been a very bad call.

> This is to me more healthy than having to bother
> and wait for each other through a mailing list.

Turnaround should be fairly quick with a trivial patch. The patch is not
going to get worse by waiting on the mailing list, but it may end up
being better, so it's a win-win situation.


> I am first a GNOME developper, where anyone can push changes without review.

This is not true, this depends on the module, the maintainer, your
relationship with that maintainer and the module, ...

> I think this rule should be left to the maintainer, and as a
> maintainer of some of the Spice project, I prefer to have a trustful
> relationship and let people commit directly.

Since you are playing the maintainer card, hopefully as a maintainer you
are going to listen how people (at least 2 ) in your project community
want to work, and not unilaterally change the way commits have been
handled in the past.

> It's really not much, if
> the change is wrong, it can be reverted, not a big deal.

Not a big deal save for history cluttering, the need to be careful when
backporting patches if the commit was followed by a fixup commit, no way
for fixing commit log typos, or for adding missing information, ...

Christophe

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141205/3f89009d/attachment-0001.sig>