[Spice-devel] [spice-common 04/13] build-sys: Move smartcard check to m4 macro

[Christophe Fergeau]

On Fri, Dec 05, 2014 at 03:49:55PM -0600, Jonathon Jongsma wrote:
> I don't have strong opinions on moving these checks into macros (or the
> following patches that extract additional macros), but 
> - Do they really need to all be in their own files? From a readability
> point of view, I think it's nicer to be able to browse all of these
> macros at once rather than opening a separate file to inspect each one

Oh I can merge them in a single file, there are no particular reason why
they are separate

> - In general, it'd be nice if the  m4 macros had their arguments
> documented in a comment at the top of the macro. Then you don't have to
> read the whole implementation to find out how to use them.

Ok, I'll add that.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141208/033f91f2/attachment.sig>