[Spice-devel] [PATCH 1/4] ppc: Get rid of CPU detection in configure.ac

[Christophe Fergeau]

On Fri, Dec 12, 2014 at 12:24:49PM -0500, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > If we add support for big endian CPUs, this check becomes obsolete, we
> > should fix bugs as they are reported on the untested archs.
> > ---
> >  configure.ac | 18 ------------------
> >  1 file changed, 18 deletions(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 4e57ef3..69d4991 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -60,24 +60,6 @@ AC_SUBST(SPICE_LT_VERSION)
> >  m4_ifndef([AS_VAR_APPEND],
> >            AC_DEFUN([AS_VAR_APPEND], $1=$$1$2))
> >  
> > -# Check for the CPU we are using
> > -#
> > -AC_MSG_CHECKING(for x86, x86-64 or armv6+ platform)
> > -case $host_cpu in
> > -  i386|i486|i586|i686|i786|k6|k7|armv6|armv6l|armv6hl|armv7|armv7l|armv7hl)
> > -	variant=32
> > -        ;;
> > -  x86_64)
> > -	variant=64
> > -	;;
> > -  *)
> > -	AC_MSG_RESULT(no)
> > -	echo Only x86 and x86-64 are supported
> > -	exit 1
> 
> Perhaps it should be a warning instead of an error? To show that nobody tried it? 

Good idea, I'll add that.

> 
> > -esac
> > -AC_MSG_RESULT($variant bit)
> > -AM_CONDITIONAL([X86_64], [test "$variant" = 64])
> 
> This conditional is never used?

grepping did not return any hits for X86_64, and I haven't seen new
automake warnings/compilation failures without it.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141215/4c9d5537/attachment.sig>