[Spice-devel] [PATCHv2 spice-gtk 0/5] Fix authentication error handling regression

Marc-André Lureau marcandre.lureau at redhat.com
Tue Dec 16 09:11:03 PST 2014


Hi,

With the recent changes in channel life-cycle, I introduced
regressions with authentication: when authentication fails, a client
may attempt to reconnect, but all channels are removed from the
session and clients may decide to quit.

This series is an attempt to fix this to keep compatibility with
current clients that expects to always have at least a channel alive
for a session to be "active".

In v2:
 - Fix regressions found by Pavel in v1

Marc-André Lureau (5):
  session: keep main channel on reconnect
  channel: factorize failed authentication
  channel: do not enter channel iterate on early error
  channel: introduce SPICE_CHANNEL_STATE_RECONNECTING
  channel: throw auth error when coroutine ends

 gtk/spice-channel-priv.h |   2 +
 gtk/spice-channel.c      | 110 ++++++++++++++++++++++++-----------------------
 gtk/spice-session.c      |  30 +++++++------
 3 files changed, 76 insertions(+), 66 deletions(-)

-- 
2.1.0



More information about the Spice-devel mailing list