[Spice-devel] [PATCH] Cleanup: move static function declarations out of header

[Christophe Fergeau]

ACK.

On Tue, Dec 23, 2014 at 09:34:52AM -0600, Jonathon Jongsma wrote:
> It doesn't make much sense to have static function declarations in a
> header, even a private header. So move them down into the source file.
> ---
>  server/reds-private.h | 4 ----
>  server/reds.c         | 4 ++++
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/server/reds-private.h b/server/reds-private.h
> index 2f9af44..953a52a 100644
> --- a/server/reds-private.h
> +++ b/server/reds-private.h
> @@ -33,10 +33,6 @@ typedef struct VDIReadBuf {
>      uint8_t data[SPICE_AGENT_MAX_DATA_SIZE];
>  } VDIReadBuf;
>  
> -static VDIReadBuf *vdi_port_read_buf_get(void);
> -static VDIReadBuf *vdi_port_read_buf_ref(VDIReadBuf *buf);
> -static void vdi_port_read_buf_unref(VDIReadBuf *buf);
> -
>  enum {
>      VDI_PORT_READ_STATE_READ_HEADER,
>      VDI_PORT_READ_STATE_GET_BUFF,
> diff --git a/server/reds.c b/server/reds.c
> index e34433b..c2a14d8 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -156,6 +156,10 @@ static void reds_char_device_add_state(SpiceCharDeviceState *st);
>  static void reds_char_device_remove_state(SpiceCharDeviceState *st);
>  static void reds_send_mm_time(void);
>  
> +static VDIReadBuf *vdi_port_read_buf_get(void);
> +static VDIReadBuf *vdi_port_read_buf_ref(VDIReadBuf *buf);
> +static void vdi_port_read_buf_unref(VDIReadBuf *buf);
> +
>  static ChannelSecurityOptions *channels_security = NULL;
>  static int default_channel_security =
>      SPICE_CHANNEL_SECURITY_NONE | SPICE_CHANNEL_SECURITY_SSL;
> -- 
> 1.9.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141223/5d4a3584/attachment-0001.sig>