[Spice-devel] [spice-gtk 04/13] http-proxy: specify Basic scheme

[Marc-André Lureau]

----- Original Message -----
> On Mon, Feb 03, 2014 at 07:02:35PM +0100, Marc-André Lureau wrote:
> > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > 
> > Or Squid will fail with:
> > WARNING: Unsupported or unconfigured/inactive proxy-auth scheme
> 
> Makes sense, ACK. If there is an upstream for wocky-http-proxy.c, have you
> sent your change there?
> 

no, but I discussed a few times with Nicolas Dufresne and other from collabora, and it would be better in glib-networking. Just a lack of time and interest to make it solid enough in both sides..

> Christophe
> 
> 
> > ---
> >  gtk/wocky-http-proxy.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/gtk/wocky-http-proxy.c b/gtk/wocky-http-proxy.c
> > index 639cfb0..7210859 100644
> > --- a/gtk/wocky-http-proxy.c
> > +++ b/gtk/wocky-http-proxy.c
> > @@ -98,7 +98,7 @@ create_request (GProxyAddress *proxy_address, gboolean
> > *has_cred)
> >        base64_cred = g_base64_encode ((guchar *) cred, strlen (cred));
> >        g_free (cred);
> >        g_string_append_printf (request,
> > -          "Proxy-Authorization: %s\r\n",
> > +          "Proxy-Authorization: Basic %s\r\n",
> >            base64_cred);
> >        g_free (base64_cred);
> >      }
> > --
> > 1.8.4.2
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>