[Spice-devel] [PATCH spice-gtk] pulse: sync volume and mute upon stream creation

[Christophe Fergeau]

On Thu, Feb 20, 2014 at 05:39:48PM +0100, Marc-André Lureau wrote:
> Whenever a stream is created, it should have current guest volume.
> Otherwise, a 100% volume guest will have current client volume, and
> when changing guest volume slightly, the volume will jump abruptly.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1012868#c10
> ---
>  gtk/spice-pulse.c | 253 +++++++++++++++++++++++++++++++++---------------------
>  1 file changed, 155 insertions(+), 98 deletions(-)


The actual bug fix is mixed with all the code movement/refactoring, can you
split this in 2 patches, one introducing the new methods you need and
making use of them in existing code, and the 2nd patch fixing the bug?

Thanks,

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140224/90fe8e50/attachment.pgp>