[Spice-devel] [PATCH] mjpeg: Don't warn when on unsupported image formats

[Marc-André Lureau]

ack

----- Original Message -----
> When trying to start mjpeg compression mode, mjpeg_encoder_start_frame()
> tests the image format as its only able to compress 24/32bpp images. On
> images with lower bit depths, we return MJPEG_ENCODER_FRAME_UNSUPPORTED to
> indicate this is not a format we can compress. However, this return goes
> with a spice_warning("unsupported format"). As the rest of the code can
> cope with this unsupported format by not doing mjpeg compression, it's
> nicer to downgrade this spice_warning() to spice_debug().
> 
> This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1070028
> ---
>  server/mjpeg_encoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/mjpeg_encoder.c b/server/mjpeg_encoder.c
> index 04b244e..aea4964 100644
> --- a/server/mjpeg_encoder.c
> +++ b/server/mjpeg_encoder.c
> @@ -796,7 +796,7 @@ int mjpeg_encoder_start_frame(MJpegEncoder *encoder,
> SpiceBitmapFmt format,
>  #endif
>          break;
>      default:
> -        spice_warning("unsupported format %d", format);
> +        spice_debug("unsupported format %d", format);
>          return MJPEG_ENCODER_FRAME_UNSUPPORTED;
>      }
>  
> --
> 1.8.5.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>