[Spice-devel] [PATCH 03/17] Move sync_write* to reds_stream.h

[Alon Levy]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/13/2014 01:00 PM, Christophe Fergeau wrote:
> On Sun, Jan 12, 2014 at 01:04:10PM +0200, Alon Levy wrote:
>> On 01/07/2014 01:14 PM, Christophe Fergeau wrote:
>>> They are renamed to reds_stream_write*
>> 
>> You also changed the return type for reds_stream_write_all (was 
>> sync_write) to bool, which is now being cast to int in some code
>> paths.
> 
> Which code path do you mean? The code paths in this patch are
> either ignoring reds_stream_write_* return values or using it as a
> boolean (with ! or &&).
> 
> Christophe
> 

My bad, I missed the boolean and in reds_send_link_error, it does cast
the bool to int (the logical and of two red_stream_write_all calls)
but that is not an error.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJS09TPAAoJEGSFt2Lm6PXueBYH/j7jXbn9oexh4kmRz4RhC1w7
91Ij34Z+S34moZq6MRHsk4nwICwiTC0EhMtOF2qz50ubH0yMUMxXMrNVwkRdiwuc
AzFbTZ+6hEOvL72kqecOUTnzUaou4UKicmBDgAtYAvx8K57hjzUZGdtc6fl5UjWq
2m7Buvx8hWKAM7inwwl33tC7wYSjYkQvedIoH3qLGAiORqAr9IvfP2/0HBFENfTR
nONr4lhWx+pIW1LtsbiVpAi8FOKbnuDW1K/gU7sVyXkLkWqpAejeN3uICTpXoczg
plwYgMUIEInKrtYAbu3Ju9+BhfMKaKOAM+Gaq+zcBa/kdp0iT8VFT0s5ISpmLsk=
=ZRoW
-----END PGP SIGNATURE-----