[Spice-devel] [Fwd: qemu builds vs spice INLINE macro]

[Gerd Hoffmann]

  Hi,

See below.  What is the reason for the INLINE macro in spice-protocol?
It looks like isn't used anywhere in the spice-protocol package.

If some other spice components depend on it: can it please be moved to a
private spice header?

thanks,
  Gerd

-------- Forwarded Message --------
From: Dr. David Alan Gilbert <dgilbert at redhat.com>
To: kraxel at redhat.com
Subject: qemu builds vs spice INLINE macro
Date: Mon, 16 Jun 2014 14:08:47 +0100

Hi Gerd,
  I'm having some build errors today on my f20 laptop
with qemu head (with 3 or 4 of my patches on, but all minor):

  CC    audio/wavcapture.o
In file included from /usr/include/spice-server/spice.h:25:0,
                 from /home/dgilbert/git/qemu-threads/include/ui/qemu-spice.h:25,
                 from /home/dgilbert/git/qemu-threads/spice-qemu-char.c:3:
/usr/include/spice-1/spice/macros.h:105:0: error: "INLINE" redefined [-Werror]
 #define INLINE inline
 ^
In file included from /home/dgilbert/git/qemu-threads/include/qemu/bswap.h:8:0,
                 from /home/dgilbert/git/qemu-threads/include/qemu-common.h:112,
                 from ./trace/generated-tracers.h:6,
                 from /home/dgilbert/git/qemu-threads/include/trace.h:4,
                 from /home/dgilbert/git/qemu-threads/spice-qemu-char.c:2:
/home/dgilbert/git/qemu-threads/include/fpu/softfloat.h:66:0: note: this is the location of the previous definition
 #define INLINE static inline

so it looks like 'INLINE' is declared in both the qemu softfloat.h and the system
spice-1/spice/macros.h

Neither of these seem a good idea, especially for a system header.

Dave
--
Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK