[Spice-devel] [spice-gtk 2/3] Include glib-compat.h at the end of config.h

[Christophe Fergeau]

On Thu, Feb 27, 2014 at 01:54:22PM +0100, Marc-André Lureau wrote:
> On Thu, Feb 27, 2014 at 1:47 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > As long as .c files include config.h, this will ensure we don't forget
> > to include glib-compat.h when needed, and only notice when someone tests
> > a RHEL6 build.
> 
> I am not really sure this is a good idea... Everything is not linking
> by default with glib-compat.c.

An occasional link error when glib-compat.c is missing from the list of
source files is less maintainance work than a build error every time a file
does not include glib-compat.h (most of spice-gtk has glib-compat.c in its
source files).

> 
> config.h should only be for #define... no?

Hmm maybe, autoconf documentation mentions using AH_BOTTOM() to include
another .h file, but they don't mention what the expected content is ;)
If you feel including this in config.h is too much magic, I'm fine with
dropping this patch and the next one.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140310/2faea811/attachment.pgp>