[Spice-devel] [PATCHv3 spice-gtk 13/14] channel: add spice_channel_get_error()

[Christophe Fergeau]

On Tue, Mar 11, 2014 at 08:15:49AM -0400, Marc-André Lureau wrote:
> > This avoids potentially losing the non-TLS error if remote-viewer is
> > started with only a non-TLS port. However, this will lose non-TLS
> > connection errors when starting QEMU with just a non-TLS port and starting
> > remote-viewer with both TLS and non-TLS ports.
> 
> Ok, we should let go proxy errors though... If we let go only proxy
> errors, I would filter that from the propagate in spice-session, not
> here.

I'm not sure how you define 'proxy errors' ? G_IO_ERROR_PROXY_* (3
different ones appear in wocky-http-proxy.c, dunno if there are more in
gio). If we filter the errors we forward, I'd probably go with only
ignoring just G_IO_ERROR_CONNECTION_REFUSED (hoping the fallback isn't
sometimes triggered by a different error when a firewall only allows
connections to the SPICE TLS port for example).

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140311/fb9c991c/attachment.pgp>