[Spice-devel] [PATCH spice-xpi 2/2] controller: return immediately if already connected

Christophe Fergeau cfergeau at redhat.com
Thu Mar 13 10:23:55 PDT 2014


On Thu, Mar 13, 2014 at 01:15:51PM -0400, Marc-André Lureau wrote:
> 
> 
> ----- Original Message -----
> > On Fri, Mar 07, 2014 at 03:02:41PM +0100, Marc-André Lureau wrote:
> > > From: Marc-André Lureau <marcandre.lureau at gmail.com>
> > > 
> > > Do not try again if the unix socket is already connected, but fail
> > > immediately.
> > 
> > Does that prevent a crash? Or what does this commit change from a end-user
> > perspective?
> 
> It only returns immediately if EISCONN, instead of trying 10x.

Ah ok, and combined with what the previous patch changes, this was causing
the crash. The crash reproducer should be described in the log of the
previous patch.

ACK to that one.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140313/6237114e/attachment.pgp>


More information about the Spice-devel mailing list