[Spice-devel] [PATCH 2/2] Use #include "common/..." in (de)marshallers

[Christophe Fergeau]

On Wed, Mar 19, 2014 at 05:52:23PM +0100, Christophe Fergeau wrote:
> On Wed, Mar 19, 2014 at 05:40:39PM +0100, Marc-André Lureau wrote:
> > On Wed, Mar 19, 2014 at 5:35 PM, Christophe Fergeau <cfergeau at redhat.com>wrote:
> > 
> > > Hey,
> > >
> > > On Wed, Mar 19, 2014 at 05:25:48PM +0100, Marc-André Lureau wrote:
> > > > aren't the #include "header" looked up in current file directory?
> > >
> > > Yes, but we have some of the generated marshallers containing #include
> > > "messages.h". These generated marshallers are in $builddir, messages.h is
> > > in $srcdir so we need an explicit -I when $srcdir != $builddir
> 
> > ok, shouldn't it use <common/..> in this case?
> 
> Sorry, #include "common/..." is used after one of the patches, but when
> building $top_builddir/spice-common/common/generated*.c we need to look up
> includes in $top_srcdir/spice-common/ if we want #include
> "common/messages.h" to be found, which is what this commit adds.

Did this answer your question?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140325/9d11a947/attachment.sig>