[Spice-devel] [PATCH 1/7] Introduce reds_stream_async_read() helper

[Christophe Fergeau]

On Tue, Mar 25, 2014 at 11:58:40AM +0100, Marc-André Lureau wrote:
> On Mon, Mar 17, 2014 at 2:20 PM, Christophe Fergeau <cfergeau at redhat.com>wrote:
> > @@ -449,6 +446,23 @@ void async_read_handler(int fd, int event, void *data)
> >      }
> >  }
> >
> > +void reds_stream_async_read(RedsStream *stream,
> > +                            uint8_t *data, size_t size,
> > +                            AsyncReadDone read_done_cb,
> > +                            void *opaque)
> > +{
> > +    AsyncRead *obj = &stream->priv->async_read;
> > +
> >
> 
> s/obj/ async or op ?

I've sent a followup patch doing that throughout the file.

> 
> 
> > +    g_assert(!obj->stream);
> >
> 
> Safer spice_return_if_fail() ?

Yup, I just fixed it locally, thanks.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140325/3711f436/attachment.sig>