[Spice-devel] [PATCH spice] server: use a warning when disconnecting unresponsive client

Christophe Fergeau cfergeau at redhat.com
Thu May 15 05:41:07 PDT 2014


On Thu, May 15, 2014 at 01:42:21PM +0200, Marc-André Lureau wrote:
> The debug level is not visible by default, since it is an undesirable
> server behaviour, make it a warning.
> ---
>  server/red_channel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/red_channel.c b/server/red_channel.c
> index 2e467af..887daa9 100644
> --- a/server/red_channel.c
> +++ b/server/red_channel.c
> @@ -818,7 +818,7 @@ static void red_channel_client_connectivity_timer(void *opaque)
>                                          rcc->connectivity_monitor.timeout);
>      } else {
>          monitor->state = CONNECTIVITY_STATE_DISCONNECTED;
> -        spice_debug("rcc %p has not been responsive for more than %u ms, disconnecting",
> +        spice_warning("rcc %p has not been responsive for more than %u ms, disconnecting",
>                      rcc, monitor->timeout);
>          red_channel_client_disconnect(rcc);

ACK, maybe we could print rcc->channel->type and rcc->channel->id while
at it?

Christophe


More information about the Spice-devel mailing list