[Spice-devel] [PATCH 2/2] [xf86-video-qxl] stability for dual head: use larger chunks when splitting image

David Mansfield spice at dm.cobite.com
Mon May 19 07:02:02 PDT 2014


The maximum number of "commands" that can be queued at once is fixed at 
compile time at MAX_RELOCS. However, during the creation of an image 
object in qxl_image_create(), the image is split into commands of 
maximum size 512*512. For a large dual-head system, it is easy to create 
an image for which the number of chunks will result in an overflow of 
MAX_RELOCS number of "commands".

Identify this scenario and dynamically increase the chunk size to avoid 
the overflow, and the resulting assert() which crashes Xorg.

Note: the debugging statement is currently enabled in this patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qxl_image_create_bigger_chunks.patch
Type: text/x-patch
Size: 1184 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140519/854949ec/attachment.bin>


More information about the Spice-devel mailing list