[Spice-devel] [PATCH] Fix make failed when uncommented COMPRESS_STAT in red_worker.c
Christophe Fergeau
cfergeau at redhat.com
Mon May 26 09:55:15 PDT 2014
Thanks, ACK and pushed to git!
Christophe
On Mon, May 26, 2014 at 05:59:57PM +0800, Wang Qiang wrote:
> From: Wang Qiang <wangqiang.hunan at gmail.com>
>
> https://bugs.freedesktop.org/show_bug.cgi?id=79246
> As a developer, I maybe want to see the detail compress stat of spice, like this:
> Method count orig_size(MB) enc_size(MB) enc_time(s)
> QUIC 846 948.02 147.22 7.51
> GLZ 2895 594.90 26.60 1.33
> ZLIB GLZ 0 0.00 0.00 0.00
> LZ 1 3.15 0.01 0.00
> JPEG 0 0.00 0.00 0.00
> JPEG-RGBA 0 0.00 0.00 0.00
> ----------------------------------------------------------------------------
> Total 3742 1546.07 173.83 8.84
>
> But when I uncommented the COMPRESS_STAT and COMPRESS_DEBUG in red_worker.c and make.
> I got some error(in Bugzilla). This error because of some simple syntax errors.
> Commit this patch to fix this issue.
>
> Signed-off-by: Wang Qiang <wangqiang.hunan at gmail.com>
> ---
> server/red_worker.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 1871e13..6e4ba54 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -257,7 +257,7 @@ static inline void stat_compress_add(stat_info_t *info, stat_time_t start, int o
> info->comp_size += comp_size;
> }
>
> -double inline stat_byte_to_mega(uint64_t size)
> +static inline double stat_byte_to_mega(uint64_t size)
> {
> return (double)size / (1000 * 1000);
> }
> @@ -1152,7 +1152,7 @@ static void print_compress_stats(DisplayChannel *display_channel)
> display_channel->zlib_glz_stat.comp_size :
> display_channel->glz_stat.comp_size;
>
> - spice_info("==> Compression stats for display %u", display_channel->common.id);
> + spice_info("==> Compression stats for display %u", display_channel->common.base.id);
> spice_info("Method \t count \torig_size(MB)\tenc_size(MB)\tenc_time(s)");
> spice_info("QUIC \t%8d\t%13.2f\t%12.2f\t%12.2f",
> display_channel->quic_stat.count,
> --
> 1.9.1
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140526/031fe5ce/attachment.sig>
More information about the Spice-devel
mailing list