[Spice-devel] [PATCH xf86-qxl] Xspice: fail if server can't be initialized

Marc-André Lureau marcandre.lureau at gmail.com
Sun Nov 2 16:15:13 PST 2014


Failure to bind to port should be an error, not a warning.

https://bugs.freedesktop.org/show_bug.cgi?id=65185
---
 src/qxl_driver.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 072953c..165f468 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -653,7 +653,10 @@ spiceqxl_screen_init (ScrnInfoPtr pScrn, qxl_screen_t *qxl)
 	qxl->spice_server = xspice_get_spice_server ();
 	xspice_set_spice_server_options (qxl->options);
 	qxl->core = basic_event_loop_init ();
-	spice_server_init (qxl->spice_server, qxl->core);
+	if (spice_server_init (qxl->spice_server, qxl->core) < 0) {
+            ErrorF ("failed to initialize server\n");
+            abort ();
+        }
 	qxl_add_spice_display_interface (qxl);
 	qxl_add_spice_playback_interface (qxl);
 	spiceqxl_vdagent_init (qxl);
-- 
1.9.3



More information about the Spice-devel mailing list