[Spice-devel] [spice-gtk] [PATCH] Provide a method to check if a USB device matches a specific class, subclass and protocol

[Fabiano Fidêncio]

Zeeshan,

On Tue, Nov 11, 2014 at 11:15 PM, Zeeshan Ali (Khattak)
<zeeshanak at gnome.org> wrote:
> On Tue, Nov 11, 2014 at 2:29 PM, Fabiano Fidêncio <fidencio at redhat.com> wrote:
>> As we only can filter USB devices by their Classes and sometimes it is
>> not enough (eg: I do not want to have Keyboard and Mouse, but want to
>> have have Joysticks, being all of them part of HID Class), provide to
>> the applications a way match the device itself with the desired Class,
>> SubClass and Protocol, so the applications refine the filter provided
>> by usbredir.
>
> I don't think its a good idea to create a separate API for this on the
> device level. I suggest either or both of following:
>
> * Extend (if possible without breaking existing API) the existing
> filtering mechanism for DeviceManager for this.

I'm not going to break/expand the filter API.
As it is now, seems to be the pattern used for RHEL tools and I am not
going to change it.

> * Provide getters for all these properties on device level so Apps can
> use that info for different things, including of course to filter
> devices in a list.

I can expose the getters, there is no problem. It was my first
approach, actually, then I've decided to expose just one method
instead of three, taking in consideration that this method is enough
for what Boxes needs.

>
>> This patch was written based on https://bugzilla.gnome.org/show_bug.cgi?id=698430
>> Any suggestion to have a shorter short-log is welcome :-)
>
> After all that practice with this in Boxes, I'm pretty sure you can do
> much better if you just try a bit.

That's the thing. I personally prefer a self-explained (not so)
short-message than a cryptic one (just because it's shorter).

Best Regards,
-- 
Fabiano Fidêncio