[Spice-devel] [PATCH spice-gtk 09/13] migration: remove unnecessary reference

Christophe Fergeau cfergeau at redhat.com
Wed Nov 12 08:24:43 PST 2014


On Wed, Nov 12, 2014 at 05:03:37PM +0100, Marc-André Lureau wrote:
> On Wed, Nov 12, 2014 at 4:14 PM, Christophe Fergeau <cfergeau at redhat.com>
> wrote:
> 
> > Hey, this one can be squashed in patch 04/13
> 
> 
> I prefer to keep this seperate to ease bisection if it introduces issues.
> Furthermore, it's not directly related to 4/13.

Yup, I was about to reply to myself that 4/13 is not the correct one,
but 8/13 is. Got confused about session->priv->migration first moving
from spice_session_set_migration to migrate_connect in 4/13, and then to
main_migrate_connect in 8/13

However, as 8/13 is mostly code movement, I agree that it's better to
keep it this way, and have the removal as an additional patch, so ACK to
this one, and disregard my comments about 4/13.

Christophe

> 
> 
> -- 
> Marc-André Lureau

> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141112/6dd114b0/attachment.sig>


More information about the Spice-devel mailing list