[Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

Christophe Fergeau cfergeau at redhat.com
Thu Nov 13 01:15:08 PST 2014


On Wed, Nov 12, 2014 at 05:56:26PM +0100, Marc-André Lureau wrote:
> On Wed, Nov 12, 2014 at 5:08 PM, Christophe Fergeau <cfergeau at redhat.com>
> wrote:
> 
> > Rereading the commit log,
> > this movement seems unrelated to what you are fixing anyway?
> >
> 
> It is related, since we change the state to connecting before requesting
> the fd, but we want to keep a warning when calling open_fd() on invalid
> states.

It seems it could have stayed in the same place, but with the check
changed to > _CONNECTING instead of != UNCONNECTED?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141113/27425350/attachment.sig>


More information about the Spice-devel mailing list