[Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

Christophe Fergeau cfergeau at redhat.com
Thu Nov 13 09:48:36 PST 2014


On Thu, Nov 13, 2014 at 04:43:26PM +0100, Marc-André Lureau wrote:
> On Thu, Nov 13, 2014 at 10:15 AM, Christophe Fergeau <cfergeau at redhat.com>
> wrote:
> 
> > It seems it could have stayed in the same place, but with the check
> > changed to > _CONNECTING instead of != UNCONNECTED?
> >
> 
> It is not the same check in the normal connect() case (== UNCONNECTED), so
> it is better to move state check in the respective callers.

AH right, I was tired yesterday, > VS >=

ACK with thecommit log improvements you suggested.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141113/ba1b26e3/attachment.sig>


More information about the Spice-devel mailing list